Skip to content

Conversation

@nickboldt
Copy link
Member

@nickboldt nickboldt commented Nov 7, 2024

What does this PR do?

chore: tweak the help message to adopt the latest example branch name (release-1.y); also make output a bit quieter and fix a bug in the plugin naming for wrapped janus idp plugins

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

Run the script without options:

./modules/dynamic-plugins/rhdh-supported-plugins.sh 

see:


Generate an updated table of dynamic plugins from content in the following two repos, for the specified branch:
* https://github.com/janus-idp/backstage-plugins
* https://github.com/janus-idp/backstage-showcase

Requires:
* jq 1.6+

Usage:

./modules/dynamic-plugins/rhdh-supported-plugins.sh -b stable-ref-branch

Options:
  -b, --ref-branch    : Reference branch against which plugin versions should be incremented, like release-1.y or main
  --clean             : Force a clean GH checkout (do not reuse files on disk)
  -h, --help          : Show this help

Examples:

  ./modules/dynamic-plugins/rhdh-supported-plugins.sh -b release-1.3 --clean

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt nickboldt changed the title chore: tweak the help message to adopt the... chore: tweak the help message to adopt the latest example branch name (release-1.y); also make output a bit quieter and fix a bug in the plugin naming for wrapped janus idp plugins Nov 7, 2024
@nickboldt nickboldt requested a review from themr0c November 7, 2024 15:23
… (release-1.y); also make output a bit quieter and fix a bug in the plugin naming for wrapped janus idp plugins

Signed-off-by: Nick Boldt <[email protected]>

regen after fixing the header and another plugin migration

Signed-off-by: Nick Boldt <[email protected]>
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Nov 7, 2024

@themr0c
Copy link
Member

themr0c commented Nov 7, 2024

Thank you for the new help!

@themr0c themr0c merged commit 42f0c49 into main Nov 8, 2024
3 checks passed
@themr0c themr0c deleted the tweak-help branch November 8, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants